Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add req for sec wg review in some cases #21896

Closed
wants to merge 2 commits into from
Closed

doc: add req for sec wg review in some cases #21896

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
260f937
doc: add req for sec wg review in some cases
mhdawson Jul 19, 2018
a4850f4
squash: address comments
mhdawson Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,13 +381,21 @@ A Pull Request should be raised and approved like any other change.

### Additions to the Cryptography and Security APIs

Semver-minor commits that add or change cryptograpy/security APIs should be
treated with extra care. Due to the potential impact, it is important that
these APIs be constructed to reduce the potential for incorrect
usage.
Semver-minor commits that add or change cryptograpy APIs and Security APIs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does tls fall under "security" or "crypto", and if it's "crypto" then are there any "security APIs" at all?

should be treated with extra care. Due to the potential impact, it is
important that these APIs be constructed to reduce the potential for
incorrect usage.

These commits must have an approval from at least one member from the
[security working group](https://github.com/nodejs/security-wg).
Semver-minor commits changing or adding cryptography or security APIs
should be made visible to the crypto team and the security working group
through an @nodejs/security-wg and @nodejs/crypto mention in the PR.

For Semver-minor commits changing cryptography APIs, they must have
an approval from at least one member from the crypto team.

For Semver-minor commits changing Security API's(other than those
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API's -> APIs like it is elsewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems extremely broad. What are our security APIs?

related to cryptography) must have an approval from at least
one member from the [security working group](https://github.com/nodejs/security-wg).

### Introducing New Modules

Expand Down