test: run ESM tests in parallel #21919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
approved these changes
Jul 21, 2018
cjihrig
approved these changes
Jul 21, 2018
|
Stress test to make sure none of these are likely to be unreliable when run in parallel: https://ci.nodejs.org/job/node-stress-single-test/1968/nodes=osx1010/console |
maclover7
approved these changes
Jul 22, 2018
|
These tests occasionally get hung up in the stress test, suggesting that they might end up being flaky/unreliable, although they also might not. I'm unable to reproduce locally. Not objecting to this landing, but wouldn't discourage anyone from investigating further if they were so inclined. |
trivikr
approved these changes
Jul 22, 2018
|
Landed in 34fb560 |
targos
added a commit
that referenced
this pull request
Aug 4, 2018
PR-URL: #21919 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
added a commit
that referenced
this pull request
Aug 4, 2018
PR-URL: #21919 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces
make jstestruns by 4-5 seconds on my machine (12 cores)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes