uv: move process.binding('uv') to internalBinding #22163
Conversation
nodejs-github-bot
added
the
lib / src
|
CITGM ( |
lpinca
added
the
semver-major
jasnell
force-pushed
the
uv-internal-binding
branch
from
d49a404
to
eb95a6a
Compare
jasnell
force-pushed
the
uv-internal-binding
branch
from
eb95a6a
to
300895b
Compare
|
New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/16307/ |
|
Redo on the custom-suites job: https://ci.nodejs.org/job/node-test-commit-custom-suites/586/ |
PR-URL: #22163 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
Landed in c7962dc |
|
Hmm, looks like the CITGM results actually show a regression in the test suite for |
|
Relevant PR from @addaleax to the |
|
@maclover7 That PR should have prevented exactly this – I think this might just be something that requires dependency updates to nyc (and/or yargs)? Also, I think this is a case where a runtime deprecation should really have been considered before landing the PR. |
|
Sigh. We can add back the process.binding export for now alongside the internalBinding. |
|
Will get a PR opened |
|
@jasnell Maybe we can wrap const forward = ['uv', ...];
const originalProcessBinding = process.binding;
process.binding = function(id) {
if (forward.includes(id)) {
process.emitWarning(...);
return internalBinding(id);
}
return originalProcessBinding(id);
};That might transitioning a bit smoother in general… |
|
That's a better approach than what I was thinking @addaleax :-) Will go that route |
Selectively deprecate `process.binding()` and fallthrough Refs: nodejs#22163
|
See #22269 |
Selectively fallthrough `process.binding()` to `internalBinding()` Refs: #22163 PR-URL: #22269 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Move
process.binding('uv')tointernalBinding('uv')/cc #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes