build: make tools/doc/node_modules non-phony #22189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
/ping @rubys @richardlau @nodejs/build-files |
richardlau
approved these changes
Aug 8, 2018
fhinkel
approved these changes
Aug 8, 2018
rubys
approved these changes
Aug 8, 2018
2 tasks
joyeecheung
approved these changes
Aug 9, 2018
Makefile
Outdated
| @@ -262,26 +262,26 @@ jstest: build-addons build-addons-napi ## Runs addon tests and JS tests | |||
| .PHONY: test | |||
| # This does not run tests of third-party libraries inside deps. | |||
| test: all ## Runs default tests, linters, and builds docs. | |||
| # Build the addons before running the tests so the test results | |||
There was a problem hiding this comment.
Is there any reason for the white space changes?
There was a problem hiding this comment.
With the indentation the comments are sent to the shell and displayed as:
# Build the addons before running the tests so the test resultsMy reasoning was that this was a mistake and that if we wanted the comments to be displayed the echo command would be used instead and without the #.
There was a problem hiding this comment.
There was a problem hiding this comment.
I just removed the commit from the PR but I can create a separate one with this change so that this one can be merged.
refack
suggested changes
Aug 9, 2018
danbev
force-pushed
the
build_tools_doc_package.json
branch
from
1191a66
to
e502580
Compare
@refack I've removed that commit from the PR. If CI comes back green could you remove you change request as I'd like to merge this? Thanks |
This commit makes the target tools/doc/node_modules a non-phony target and also adds tools/doc/package.json as a prerequisite to it to avoid running it unnecessary. This is currently causing the target test/addons/.docbuildstamp to be always be executed as it has tools/doc/node_modules as a prerequisite.
danbev
force-pushed
the
build_tools_doc_package.json
branch
from
e502580
to
b99e529
Compare
|
Landed in 88bff82. |
danbev
added a commit
that referenced
this pull request
Aug 10, 2018
This commit makes the target tools/doc/node_modules a non-phony target and also adds tools/doc/package.json as a prerequisite to it to avoid running it unnecessary. This is currently causing the target test/addons/.docbuildstamp to be always be executed as it has tools/doc/node_modules as a prerequisite. PR-URL: #22189 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sam Ruby <rubys@intertwingly.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
This commit makes the target tools/doc/node_modules a non-phony target and also adds tools/doc/package.json as a prerequisite to it to avoid running it unnecessary. This is currently causing the target test/addons/.docbuildstamp to be always be executed as it has tools/doc/node_modules as a prerequisite. PR-URL: #22189 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sam Ruby <rubys@intertwingly.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the target
tools/doc/node_modulesa non-phony targetand also adds
tools/doc/package.jsonas a prerequisite to it to avoidrunning it unnecessary. This is currently causing the target
test/addons/.docbuildstampto be always be executed as it hastools/doc/node_modulesas a prerequisite.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes