[v8.x-backport] n-api: create functions directly #22202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
MylesBorins
force-pushed
the
v8.x-staging
branch
from
50ccfec
to
0c9760d
Compare
|
The PR seems to need a rebase… |
gabrielschulhof
force-pushed
the
backport-21688-to-v8.x
branch
from
71effc9
to
24610d6
Compare
|
@TimothyGu rebased. |
|
@gabrielschulhof and again… |
MylesBorins
force-pushed
the
v8.x-staging
branch
from
ee9dab7
to
69efa9f
Compare
Avoid using `v8::FunctionTemplate::New()` when using `v8::Function::New()` suffices. This ensures that individual functions can be gc-ed and that functions can be created dynamically without running out of memory. PR-URL: nodejs#21688 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
gabrielschulhof
force-pushed
the
backport-21688-to-v8.x
branch
from
24610d6
to
3078ccf
Compare
|
CI for rebase: https://ci.nodejs.org/job/node-test-pull-request/16486/ |
This was referenced Aug 17, 2018
|
landed in 35a8ff7 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
Avoid using `v8::FunctionTemplate::New()` when using `v8::Function::New()` suffices. This ensures that individual functions can be gc-ed and that functions can be created dynamically without running out of memory. Backport-PR-URL: #22202 PR-URL: #21688 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using
v8::FunctionTemplate::New()when usingv8::Function::New()suffices. This ensures that individual functionscan be gc-ed and that functions can be created dynamically without
running out of memory.
PR-URL: #21688
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes