Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: add multipleResolves event #22218

Closed
wants to merge 3 commits into from

Commits on Sep 18, 2018

  1. process: add multipleResolves event

    This adds the `multipleResolves` event to track promises that resolve
    more than once or that reject after resolving.
    
    It is important to expose this to the user to make sure the
    application runs as expected. Without such warnings it would be very
    hard to debug these situations.
    
    Fixes: nodejs/promises-debugging#8
    BridgeAR committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    0755912 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. fixup: address comments

    This wraps the emit in a nextTick to have a individual context
    instead of ending up in a potential promise catch handler. It also
    renames the types to `resolve` and `reject` to be more neutral.
    On top of that the message was removed to reflect the `type` change.
    BridgeAR committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    4db7e53 View commit details
    Browse the repository at this point in the history
  2. fixup

    BridgeAR committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    065054b View commit details
    Browse the repository at this point in the history