Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick dbfcc48 from upstream V8 #22224

Closed
wants to merge 0 commits into from
Closed

deps: cherry-pick dbfcc48 from upstream V8 #22224

wants to merge 0 commits into from

Conversation

alexkozy
Copy link
Member

Original commit message:

[inspector] added V8InspectorClient::resourceNameToUrl

Some clients (see Node.js) use platform path as ScriptOrigin.
Reporting platform path in protocol makes using protocol much harder.
This CL introduced V8InspectorClient::resourceNameToUrl method that
is called for any reported using protocol url.
V8Inspector uses url internally as well so protocol client may generate
pattern for blackboxing with file urls only and does not need to build
complicated regexp that covers files urls and platform paths on
different platforms.

R=lushnikov@chromium.org
TBR=yangguo@chromium.org

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iff302e7441df922fa5d689fe510f5a9bfd470b9b
Reviewed-on: https://chromium-review.googlesource.com/1164624
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55029}

Refs: v8/v8@dbfcc48
Needed for #22223

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Aug 10, 2018
@alexkozy
Copy link
Member Author

/cc @eugeneo @ofrobots @hashseed

I created a bug that describes what is happening here: #22223.
Please take a look! Looking forward for your feedback.

@mscdex
Copy link
Contributor

mscdex commented Aug 10, 2018

I think the v8_embedder_string in common.gypi needs to be updated as well?

@alexkozy
Copy link
Member Author

Yes! Done.

@alexkozy alexkozy added the inspector Issues and PRs related to the V8 inspector protocol label Aug 10, 2018
@alexkozy alexkozy closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants