Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: unmark tests as flaky #22253

Merged
merged 0 commits into from
Aug 13, 2018
Merged

inspector: unmark tests as flaky #22253

merged 0 commits into from
Aug 13, 2018

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 10, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

No failures across 1000 runs (red bots seem to be unsupported): https://ci.nodejs.org/job/node-stress-single-test/1979/

@nodejs-github-bot
Copy link
Collaborator

@eugeneo build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/510/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 10, 2018
@Trott Trott mentioned this pull request Aug 10, 2018
Closed
addaleax
addaleax approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

maclover7
maclover7 approved these changes Aug 11, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@Trott
Copy link
Member

Trott commented Aug 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16363/

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol labels Aug 11, 2018
@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16377/

@eugeneo eugeneo closed this Aug 13, 2018
@eugeneo eugeneo deleted the tests_not_flaky branch August 13, 2018 16:24
@eugeneo eugeneo merged commit 2eb78e6 into nodejs:master Aug 13, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@eugeneo @rvagg
inspector: unmark tests as flaky
64c89d2 
PR-URL: #22253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@rvagg rvagg mentioned this pull request Aug 15, 2018
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkozy alexkozy alexkozy approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.