Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move process.binding('tcp_wrap') to internal #22432

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Aug 21, 2018

This commit makes the tcp_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tcp_wrap')
to use internalBinding instead.

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 21, 2018
@danbev
Copy link
Contributor Author

danbev commented Aug 21, 2018

@danbev danbev added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 21, 2018
@@ -19,6 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

// Flags: --expose-internals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this now needed? The same in the part below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is that there is a call of the function common.hasMultiLocalhost() below this line which now uses require('internal/test/binding').

This commit makes the tcp_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tcp_wrap')
to use internalBinding instead.

Refs: nodejs#22160
@danbev danbev force-pushed the tcp_wrap_move_internalBinding branch from 6a28092 to a2f97bc Compare August 24, 2018 05:49
@danbev
Copy link
Contributor Author

danbev commented Aug 24, 2018

@danbev
Copy link
Contributor Author

danbev commented Aug 24, 2018

Landed in 57d98bc.

@danbev danbev closed this Aug 24, 2018
@danbev danbev deleted the tcp_wrap_move_internalBinding branch August 24, 2018 07:26
danbev added a commit that referenced this pull request Aug 24, 2018
This commit makes the tcp_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tcp_wrap')
to use internalBinding instead.

Refs: #22160

PR-URL: #22432
Refs: #22160
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants