Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix make format-cpp-build #22481

Closed
wants to merge 1 commit into from
Closed

tools: fix make format-cpp-build #22481

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Aug 23, 2018

Fix a regression introduced by #22399

Please 👍 for fast tracking.

Ref: #22399 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@refack refack added tools Issues and PRs related to the tools directory. regression Issues related to regressions. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 23, 2018
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/645/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 23, 2018
@refack refack changed the title Fix format cpp build tools: fix make format-cpp-build Aug 23, 2018
@refack
Copy link
Contributor Author

refack commented Aug 23, 2018

/CC @nodejs/build-files @nodejs/linting

@refack
Copy link
Contributor Author

refack commented Aug 24, 2018

Closing in favor of #22500

@refack refack closed this Aug 24, 2018
@refack refack deleted the fix-format-cpp-build branch August 24, 2018 12:39
@refack refack mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refack @nodejs-github-bot @joyeecheung