-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src,cli: make CLI options programmatically accessible & generate --help text #22490
Conversation
@addaleax sadly an error occured when I tried to trigger a build :( |
Also, /cc @boneskull for the first commit |
Provide `internalBinding('options')` with some utilities around making the options parser and current options values programatically accessible.
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested.
CI: https://ci.nodejs.org/job/node-test-pull-request/16823/ (:heavy_check_mark:) |
CI is good. Anything I can do to attract reviewers without having to go into making noisy pings…? ;) |
I will try to the best of my ability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I have nothing to say. This is really nice 😄
Provide `internalBinding('options')` with some utilities around making the options parser and current options values programatically accessible. PR-URL: #22490 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested. PR-URL: #22490 Reviewed-By: Michaël Zasso <targos@protonmail.com>
This will need a small backport to v10.x-staging. |
Provide `internalBinding('options')` with some utilities around making the options parser and current options values programatically accessible. PR-URL: nodejs#22490 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested. PR-URL: nodejs#22490 Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax due to a misconfigured job in CI the job was marked "Unstable" even tough this has a failed test
|
I'm running a test to see if the job will now fail. If #22657 doesn't get fast-tracked I'll revert that change for the time being. Update: https://ci.nodejs.org/job/node-test-commit-linux-containered/6806/nodes=ubuntu1604_sharedlibs_withoutintl_x64/console, configuration fixed. Now the job fails. |
It was called --security-revert prior to 12.x, but changed in nodejs#22490. See: nodejs/nodejs.org#2412 (comment)
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`node --help` before:
`node --help` after:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes