Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: ensure readdir() callback is only called once #22793

Closed
wants to merge 1 commit into from
Closed

fs: ensure readdir() callback is only called once #22793

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 10, 2018

This commit ensures that the readdir() callback can only be called once when the withFileTypes parameter is supplied.

Fixes: #22778

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
fs: ensure readdir() callback is only called once
d262489 
This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. util Issues and PRs related to the built-in util module. labels Sep 10, 2018
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/851/pipeline

@addaleax
Copy link
Member

This seems like it might also be a candidate for fast-tracking if we’re doing a 10.10.1 release this week (the other one being #22790), right?

@danbev
Copy link
Contributor

danbev commented Sep 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17169/

@danbev
Copy link
Contributor

danbev commented Sep 13, 2018

Landed in 466cda0.

@danbev danbev closed this Sep 13, 2018
danbev pushed a commit that referenced this pull request Sep 13, 2018
@cjihrig @danbev
fs: ensure readdir() callback is only called once
466cda0 
This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.

PR-URL: #22793
Fixes: #22778
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@cjihrig cjihrig deleted the withfiletypes branch September 13, 2018 12:34
targos pushed a commit that referenced this pull request Sep 15, 2018
@cjihrig @targos
fs: ensure readdir() callback is only called once
4159000 
This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.

PR-URL: #22793
Fixes: #22778
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@cjihrig @targos
fs: ensure readdir() callback is only called once
e9b5c34 
This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.

PR-URL: #22793
Fixes: #22778
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
@cjihrig @targos
fs: ensure readdir() callback is only called once
f0a4017 
This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.

PR-URL: #22793
Fixes: #22778
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajafff ajafff ajafff approved these changes

@JungMinu JungMinu JungMinu approved these changes

@bengl bengl bengl approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @addaleax @danbev @apapirovski @bengl @JungMinu @ajafff