Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing history entry for withFileTypes in fs.readDir(Sync) #22794

Closed
wants to merge 1 commit into from
Closed

docs: Add missing history entry for withFileTypes in fs.readDir(Sync) #22794

wants to merge 1 commit into from

Conversation

tiendq
Copy link
Contributor

@tiendq tiendq commented Sep 10, 2018

Fixes: #22777

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Sep 10, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just a possible nit)

doc/api/fs.md Outdated
@@ -2400,6 +2400,9 @@ a `Promise` for an `Object` with `bytesRead` and `buffer` properties.
<!-- YAML
added: v0.1.8
changes:
- version: v10.10.0
pr-url: https://github.com/nodejs/node/pull/22020
description: Added new option `withFileTypes`.
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Sep 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe New option `withFileTypes` was added? Most of the similar entries seem to follow this pattern in this doc.

doc/api/fs.md Outdated
@@ -2441,6 +2444,9 @@ If `options.withFileTypes` is set to `true`, the `files` array will contain
<!-- YAML
added: v0.1.21
changes:
- version: v10.10.0
pr-url: https://github.com/nodejs/node/pull/22020
description: Added new option `withFileTypes`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/868/

vsemozhetbyt pushed a commit that referenced this pull request Sep 12, 2018
@tiendq @vsemozhetbyt
doc: add history for withFileTypes in fs.readdir[Sync]()
2c43da8 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@vsemozhetbyt
Copy link
Contributor

Landed in 2c43da8
Thank you!

targos pushed a commit that referenced this pull request Sep 14, 2018
@tiendq @targos
doc: add history for withFileTypes in fs.readdir[Sync]()
09ae073 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@tiendq @targos
doc: add history for withFileTypes in fs.readdir[Sync]()
58d0833 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Sep 20, 2018
@tiendq @targos
doc: add history for withFileTypes in fs.readdir[Sync]()
6786730 
PR-URL: #22794
Fixes: #22777
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiendq @vsemozhetbyt @addaleax @nodejs-github-bot