Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove string literals for strictEquals/notStrictEquals #22891

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/fixtures/not-main-module.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

const assert = require('assert');
assert.notStrictEqual(module, require.main, 'require.main should not == module');
assert.notStrictEqual(module, process.mainModule,
'process.mainModule should not === module');
assert.notStrictEqual(module, require.main);
assert.notStrictEqual(module, process.mainModule);
8 changes: 2 additions & 6 deletions test/parallel/test-async-wrap-trigger-id.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,12 @@ process.nextTick(() => {
triggerAsyncId1 = triggerAsyncId();
assert.notStrictEqual(
This conversation was marked as resolved.
Show resolved Hide resolved
triggerAsyncId0,
triggerAsyncId1,
'Async resources having different causal ancestry ' +
'should have different triggerAsyncIds');
This conversation was marked as resolved.
Show resolved Hide resolved
triggerAsyncId1);
});
process.nextTick(() => {
const triggerAsyncId2 = triggerAsyncId();
assert.strictEqual(
triggerAsyncId1,
triggerAsyncId2,
'Async resources having the same causal ancestry ' +
'should have the same triggerAsyncId');
This conversation was marked as resolved.
Show resolved Hide resolved
triggerAsyncId2);
});
});