Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker,coverage: support V8 coverage generation #22928

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 18, 2018

This is currently blocked on #22927. (The first commit in this PR is included from there.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added blocked PRs that are blocked by other issues or PRs. worker Issues and PRs related to Worker support. coverage Issues and PRs related to native coverage support. labels Sep 18, 2018
@addaleax addaleax requested a review from bcoe September 18, 2018 11:15
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Sep 18, 2018
@addaleax addaleax removed c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Sep 18, 2018
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label Sep 19, 2018
@addaleax
Copy link
Member Author

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 19, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17322/ (:heavy_check_mark:)

@addaleax
Copy link
Member Author

Landed in 0dbc8c8

@addaleax addaleax closed this Sep 21, 2018
@addaleax addaleax deleted the worker-coverage branch September 21, 2018 17:15
addaleax added a commit that referenced this pull request Sep 21, 2018
PR-URL: #22928
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@@ -79,6 +79,23 @@ function nextdir() {
assert.strictEqual(fixtureCoverage.functions[2].ranges[1].count, 0);
}

// outputs coverage from worker.
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for seeing this through @addaleax

targos pushed a commit that referenced this pull request Sep 25, 2018
PR-URL: #22928
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. coverage Issues and PRs related to native coverage support. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants