test: mark some tests as flaky #22941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
added
test
|
cc @nodejs/testing |
cjihrig
approved these changes
Sep 19, 2018
BridgeAR
approved these changes
Sep 19, 2018
BridgeAR
added
the
author ready
addaleax
approved these changes
Sep 19, 2018
jasnell
approved these changes
Sep 19, 2018
refack
approved these changes
Sep 19, 2018
Refs: nodejs#20750 Refs: nodejs#22327 Refs: nodejs#22762 Refs: nodejs/reliability#16 PR-URL: nodejs#22941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
force-pushed
the
joaocgreis-I9J-flaky-tests
branch
from
f0edd8c
to
311e72f
Compare
|
Landed in 311e72f |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
Refs: #20750 Refs: #22327 Refs: #22762 Refs: nodejs/reliability#16 PR-URL: #22941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks as flaky 4 tests that have recently failed in CI and don't have PRs open to fix.
Please approve for fast-tracking, feel free to land when the necessary conditions are met.
Refs: #20750
Refs: #22327
Refs: #22762
Refs: nodejs/reliability#16
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes