Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: do not swallow errors in nested REPLs #23004

Closed
wants to merge 2 commits into from
Closed

repl: do not swallow errors in nested REPLs #23004

wants to merge 2 commits into from

Commits on Sep 21, 2018

  1. repl: do not swallow errors in nested REPLs 

    For tab completion, a REPLServer instance will sometimes create another
REPLServer instance. If a callback is sent to the `.complete()` function
and that callback throws an error, it will be swallowed by the nested
REPLs domain. Re-throw the error so that processes don't silently exit
without any indication of an error (including a status code).

Fixes: nodejs#21586
    @Trott
    Trott committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    5903929 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. squash! remove extra newline

    @Trott
    Trott authored Oct 2, 2018
    Configuration menu
    Copy the full SHA
    cac968a View commit details
    Browse the repository at this point in the history