-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve instruction to purple merge #23007
Conversation
I think you also need to push to your branch before you push to upstream. Can that be mentioned? |
Like in the line above that 😉 |
@refack i mean the explicit order. if you push to upstream before your branch it closes it but does it red instead of purple. |
Gotcha |
COLLABORATOR_GUIDE.md
Outdated
red closed status. If you close the PR before GitHub adjusts its status, it will | ||
show up as a 0 commit PR and the changed file history will be empty. Also if you | ||
push upstream before you push to your branch, GitHub will close the issue with | ||
red status so the order of operations important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably operations important -> operations is important. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Landed in 938b269. |
PR-URL: #23007 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #23007 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes