Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,msi: display license notes before installing tools #23044

Closed

Conversation

joaocgreis
Copy link
Member

Refs: #23003 (comment)

This adds notes about the licenses of packages installed by Chocolatey to the installation script. This was adapted from the README of https://github.com/Microsoft/windows-dev-box-setup-scripts/ .

Please note that there is no more space in one default console window (80x25). To add more information, either something must be deleted or another screen needs to be created.

cc @refack @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joaocgreis joaocgreis added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. dont-land-on-v6.x labels Sep 24, 2018
@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Sep 24, 2018
@joaocgreis
Copy link
Member Author

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2018
@joaocgreis
Copy link
Member Author

Resumed CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/17413/ (all green)

I will land this tomorrow if there are no objections.

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2018
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2018
joaocgreis added a commit that referenced this pull request Sep 26, 2018
PR-URL: #23044
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joaocgreis
Copy link
Member Author

Landed in d6a6df9

Thanks for your reviews @refack @addaleax @jasnell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants