Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove outdated notes on stdio in workers #23054

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Workers support stdio streams since the initial PR landed. These
lines are editing leftovers from before that and should be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Workers support `stdio` streams since the initial PR landed. These
lines are editing leftovers from before that and should be removed.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/994/pipeline

Edit: 👍 this comment to approve fast-tracking.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 24, 2018
@addaleax addaleax added worker Issues and PRs related to Worker support. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 24, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2018
@addaleax
Copy link
Member Author

Landed in a5b92a7

@addaleax addaleax closed this Sep 24, 2018
@addaleax addaleax deleted the worker-stdio-doc branch September 24, 2018 16:42
addaleax added a commit that referenced this pull request Sep 24, 2018
Workers support `stdio` streams since the initial PR landed. These
lines are editing leftovers from before that and should be removed.

PR-URL: #23054
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 24, 2018
Workers support `stdio` streams since the initial PR landed. These
lines are editing leftovers from before that and should be removed.

PR-URL: #23054
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants