doc: deeper link to downloads site #23084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @nodejs/documentation @nodejs/website |
|
Did you mean s/depper/deeper/ ? |
addaleax
approved these changes
Sep 25, 2018
lpinca
approved these changes
Sep 25, 2018
refack
changed the title
refack
force-pushed
the
readme-dl-link
branch
from
22704ef
to
b993b38
Compare
Yes thank you, fixed. (although it could have been "dapper") |
lundibundi
approved these changes
Sep 25, 2018
trivikr
approved these changes
Sep 25, 2018
trivikr
added
the
author ready
thefourtheye
approved these changes
Sep 26, 2018
gdams
approved these changes
Sep 27, 2018
targos
approved these changes
Sep 27, 2018
tniessen
approved these changes
Sep 27, 2018
|
Resume (just for good measure): https://ci.nodejs.org/job/node-test-commit/21824/ |
refack
force-pushed
the
readme-dl-link
branch
from
b993b38
to
d228c4d
Compare
refack
added a commit
to refack/node
that referenced
this pull request
Sep 28, 2018
PR-URL: nodejs#23084 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in d228c4d |
targos
pushed a commit
that referenced
this pull request
Sep 28, 2018
PR-URL: #23084 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23084 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
https://nodejs.org/en/download/instead ofhttps://nodejs.org/as the link to "downloads".The
/en/part is a bit unfortunate, but the rest of the doc is in english, so its at least consistent.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes