Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add pgo specific variables to common.gypi #23102

Closed

Conversation

lundibundi
Copy link
Member

To make sure this doesn't get lost.
@refack PTAL.

Refs: #22772 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 26, 2018
@lundibundi lundibundi added the needs-ci PRs that need a full CI run. label Sep 26, 2018
@refack
Copy link
Contributor

refack commented Sep 26, 2018

@refack PTAL.

Ohh, thank you for picking this up!

@refack
Copy link
Contributor

refack commented Sep 26, 2018

/CC @nodejs/build-files @nodejs/gyp

@lundibundi
Copy link
Member Author

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 30, 2018
@addaleax
Copy link
Member

@lundibundi
Copy link
Member Author

@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

Landed in 6f7fd7f, thanks for doing the PR!

@addaleax addaleax closed this Oct 4, 2018
addaleax pushed a commit that referenced this pull request Oct 4, 2018
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 5, 2018
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants