Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: fix session resumption check #2312

Closed
wants to merge 2 commits into from
Closed

tls: fix session resumption check #2312

wants to merge 2 commits into from

Commits on Aug 8, 2015

  1. tls: introduce internal onticketkeycallback 

    `enableTicketKeyCallback` and `onticketkeycallback` could be potentially
used to renew the TLS Session Tickets before they expire. However this
commit will introduce it only for private use yet, because we are not
sure about the API, and already need this feature for testing.

See: nodejs#2304
PR-URL: nodejs#2312
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    @indutny
    indutny committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    e41618d View commit details
    Browse the repository at this point in the history

  2. tls: fix check for reused session 

    When TLS Session Ticket is renewed by server - no Certificate record is
to the client. We are prepared for empty certificate in this case, but
this relies on the session reuse check, which was implemented
incorrectly and was returning false when the TLS Session Ticket was
renewed.

Use session reuse check provided by OpenSSL instead.

Fix: nodejs#2304
PR-URL: nodejs#2312
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    @indutny
    indutny committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    f8cc1ed View commit details
    Browse the repository at this point in the history