Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: formalize non-const reference usage in C++ style guide #23155

Closed
wants to merge 5 commits into from
Closed

doc: formalize non-const reference usage in C++ style guide #23155

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73139a5
doc: formalize non-const reference usage in C++ style guide
addaleax Sep 22, 2018
8daa18e
squash! doc: formalize non-const reference usage in C++ style guide
addaleax Oct 1, 2018
e9f8406
fixup! squash! doc: formalize non-const reference usage in C++ style …
addaleax Oct 1, 2018
acba30d
fixup! fixup! squash! doc: formalize non-const reference usage in C++…
addaleax Oct 2, 2018
04f941a
fixup! fixup! fixup! squash! doc: formalize non-const reference usage…
addaleax Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CPP_STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
* [Memory allocation](#memory-allocation)
* [Use `nullptr` instead of `NULL` or `0`](#use-nullptr-instead-of-null-or-0)
* [Ownership and Smart Pointers](#ownership-and-smart-pointers)
* [Avoid non-const references](#avoid-non-const-references)
* [Others](#others)
* [Type casting](#type-casting)
* [Do not include `*.h` if `*-inl.h` has already been included](#do-not-include-h-if--inlh-has-already-been-included)
Expand Down Expand Up @@ -200,6 +201,11 @@ void FooConsumer(std::unique_ptr<Foo> ptr);

Never use `std::auto_ptr`. Instead, use `std::unique_ptr`.

### Avoid non-const references

Using non-const references often obscures which values are changed by an
joyeecheung marked this conversation as resolved.
Show resolved Hide resolved
refack marked this conversation as resolved.
Show resolved Hide resolved
refack marked this conversation as resolved.
Show resolved Hide resolved
assignment. A pointer is almost always a better choice.

## Others

### Type casting
Expand Down