Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and gyp fixes #23156

Merged
merged 4 commits into from
Oct 2, 2018
Merged

Build and gyp fixes #23156

merged 4 commits into from
Oct 2, 2018

Commits on Oct 2, 2018

  1. build: reduce chance of unneeded rebuild 

    Run `node_js2c` and `mkssldef` as actions and not as targets makes sure
they are run only once, just before processing the rest of `node_lib`.
This helps `make` based dependency change detection be more accurate.

Add comments with tagrget names for readability.

Use `process_outputs_as_sources` for automatic inclution of outputs.

PR-URL: nodejs#23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    6dd4a07 View commit details
    Browse the repository at this point in the history

  2. build: encapsulate node/inspector gyp scafolding 

    PR-URL: nodejs#23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    375e16e View commit details
    Browse the repository at this point in the history

  3. tools,gyp: cosmetic change to GYP make generator outputs 

    Puts the compilation target upfront for easy reading.

PR-URL: nodejs#23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    731a72f View commit details
    Browse the repository at this point in the history

  4. tools,gyp: don't force build actions with multiple outputs 

    Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal.
Adding it makes the action run alway, even when there are no changes.
(refack): AFAICT because `*.intermediate` files don't have build rules.

PR-URL: nodejs#23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 2, 2018
    1 Configuration menu
    Copy the full SHA
    5d8373a View commit details
    Browse the repository at this point in the history