Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify cluster worker.kill() caveat #23165

Merged
merged 2 commits into from
Oct 4, 2018
Merged

doc: specify cluster worker.kill() caveat #23165

merged 2 commits into from
Oct 4, 2018

Commits on Oct 4, 2018

  1. doc: specify cluster worker.kill() caveat 

    worker.kill() relies on a graceful disconnect, which might not
always be possible. This commit calls this out in the docs, and
specifies worker.process.kill() as a non-graceful alternative.

PR-URL: nodejs#23165
Fixes: nodejs#22703
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @cjihrig
    cjihrig committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    a5c2709 View commit details
    Browse the repository at this point in the history

  2. test: terminate cluster worker in infinite loop 

    Verify that worker.process.kill() can terminate a cluster worker
stuck in an infinite loop.

PR-URL: nodejs#23165
Fixes: nodejs#22703
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @cjihrig
    cjihrig committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    1f7b6a6 View commit details
    Browse the repository at this point in the history