Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test-gc-http-client-onerror #23196

Closed
wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

@lundibundi lundibundi commented Oct 1, 2018

  • refactor out usage of 'function' for scoping
  • inline runTest function
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@lundibundi lundibundi self-assigned this Oct 1, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 1, 2018
@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

decrease amount of requests 500 -> 300

I think that might help with masking a real problem, see nodejs/reliability#18 (comment).

* refactor out usage of 'function' for scoping
* inline runTest function
@lundibundi
Copy link
Member Author

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2018
@addaleax
Copy link
Member

Landed in 0ea804a

@addaleax addaleax closed this Oct 12, 2018
addaleax pushed a commit that referenced this pull request Oct 12, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit that referenced this pull request Oct 13, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Oct 13, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants