Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] backport commits #23226

Closed
wants to merge 2 commits into from
Closed

[v10.x] backport commits #23226

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Oct 2, 2018

See commits.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR requested a review from targos October 2, 2018 20:34
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1101/pipeline

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. build Issues and PRs related to build files or the CI. util Issues and PRs related to the built-in util module. v10.x labels Oct 2, 2018
@targos
Copy link
Member

targos commented Oct 3, 2018 •
edited
Loading

Sorry, I had to change a commit on the staging branch so this must be rebased.

@BridgeAR
assert: improve diff output
8dcf60b 
The output is now a tiny bit improved by sorting object properties
when inspecting the values that are compared with each other. That
reduces the overall diff for identical objects with a different
property insertion order.

PR-URL: nodejs#22788
Refs: nodejs#22763
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR
util: move inspect in separate file
a666cb7 
The inspect function became very big and it's better to handle this
in a separate file.

PR-URL: nodejs#22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented Oct 3, 2018

Done

@targos
Copy link
Member

targos commented Oct 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17645/

targos pushed a commit that referenced this pull request Oct 5, 2018
@BridgeAR @targos
assert: improve diff output
2b53f17 
The output is now a tiny bit improved by sorting object properties
when inspecting the values that are compared with each other. That
reduces the overall diff for identical objects with a different
property insertion order.

Backport-PR-URL: #23226
PR-URL: #22788
Refs: #22763
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Oct 5, 2018
@BridgeAR @targos
util: move inspect in separate file
cbd851f 
The inspect function became very big and it's better to handle this
in a separate file.

Backport-PR-URL: #23226
PR-URL: #22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Oct 5, 2018

Landed in 2b53f17 and cbd851f

@targos targos closed this Oct 5, 2018
targos pushed a commit that referenced this pull request Oct 7, 2018
@BridgeAR @targos
assert: improve diff output
efdb326 
The output is now a tiny bit improved by sorting object properties
when inspecting the values that are compared with each other. That
reduces the overall diff for identical objects with a different
property insertion order.

Backport-PR-URL: #23226
PR-URL: #22788
Refs: #22763
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
@BridgeAR @targos
util: move inspect in separate file
77de1be 
The inspect function became very big and it's better to handle this
in a separate file.

Backport-PR-URL: #23226
PR-URL: #22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR deleted the backport-to-10 branch January 20, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. build Issues and PRs related to build files or the CI. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BridgeAR @nodejs-github-bot @targos