-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "module: fix inconsistency between load and _findPath" #23228
Conversation
It's fine, you don't have to. The rules allow revert messages generated by git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so long as we have an alternative approach to address the original change here.
@jdalton this needs a rebase to pass. That is automatically done on the CI but not on travis. |
This reverts commit 1b92214 from PR #22382. See the discussion at nodejs/citgm#604 Refs: #22382 Fixes: #4778
@BridgeAR Rebased but no luck. |
@jdalton the failures are different ones now. I just restarted it to see if the failures are consistent. |
CI: https://ci.nodejs.org/job/node-test-pull-request/17720/ |
Landed in b6dcf8c. |
Thank you @danbev! |
This reverts commit 1b92214 to resolve nodejs/citgm#604.
I'll rebase-up making the commit message conform to the rules. I wanted to just get this rolling.
I've been pair programming with @GeoffreyBooth on a follow-up PR to address the inconsistency that #22382 attempted to resolve.
Checklist