test: fix broken test #23232
Closed
test: fix broken test #23232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Trott
approved these changes
Oct 3, 2018
|
Possibly related to #23109, by the way. |
|
👍 here to approve fast-tracking to unbreak CI. |
refack
approved these changes
Oct 3, 2018
jasnell
approved these changes
Oct 3, 2018
gireeshpunathil
approved these changes
Oct 3, 2018
addaleax
approved these changes
Oct 3, 2018
|
Do we want to wait for a fully green CI? That’s what the rules say but it seems like a good idea to land this asap… |
|
Rebuild the only red part of the last CI run: https://ci.nodejs.org/job/node-test-commit-linux-containered/7526/ |
thefourtheye
approved these changes
Oct 3, 2018
|
Landed in 7aeda94. |
danbev
pushed a commit
that referenced
this pull request
Oct 3, 2018
Approved for fast-tracking by: Rich Trott <rtrott@gmail.com> Colin Ihrig <cjihrig@gmail.com> Refael Ackermann <refack@gmail.com> James M Snell <jasnell@gmail.com> Gireesh Punathil <gpunathi@in.ibm.com> Anna Henningsen <anna@addaleax.net> Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #23232 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Thanks for fixing this right away. |
2 tasks
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Approved for fast-tracking by: Rich Trott <rtrott@gmail.com> Colin Ihrig <cjihrig@gmail.com> Refael Ackermann <refack@gmail.com> James M Snell <jasnell@gmail.com> Gireesh Punathil <gpunathi@in.ibm.com> Anna Henningsen <anna@addaleax.net> Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #23232 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #23231