deps: upgrade to npm 2.13.4 #2328
Conversation
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d1992, 5de334c, and da730c7. This commit squashes them into a single commit. PR-URL: nodejs#990 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Conflicts: deps/npm/node_modules/node-gyp/lib/install.js
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background. PR-URL: nodejs#1433 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
brendanashworth
added
the
npm
|
The first commit in the changelog 404s for me. Should npm/npm@3e58c48 be npm/npm@2e58c48? |
|
So confused as to how that happened. Thanks for finding it! It's been corrected. :) |
| @@ -172,7 +172,7 @@ | |||
| "deep-equal": "~1.0.0", | |||
| "marked": "~0.3.3", | |||
| "marked-man": "~0.1.5", | |||
| "nock": "~2.7.0", | |||
| "nock": "~2.9.1", | |||
There was a problem hiding this comment.
I don't see any changes for nock in the files here?
There was a problem hiding this comment.
We don't include devDependency stuff in the distribution, but still bump the versions in package.json. Is that what you meant?
|
Might be nitpick, but is there any way to shrink these bumps? Most changes seems to be version or date changes -- is that for instance able to live somewhere else? |
I guess it would be nice if the doc stuff was built on our build but I don't think the extra deps are worthwhile. You just need to mostly get used to skipping over a lot of similar docs stuff if you review the changes. I suspect in git it compresses quite well, so I'm not worried about the doc version updates increasing tarball size. |
|
Closing this as obsolete, #2696 introduced npm 2.14.2 in master. |
Release notes: https://github.com/npm/npm/releases/tag/v2.13.4
Fixes
npm versionwhen used in git submodules.r: @Fishrock123
r: @chrisdickinson