Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected parameter name for napi_is_error description. #23310

Closed
wants to merge 1 commit into from
Closed

Corrected parameter name for napi_is_error description. #23310

wants to merge 1 commit into from

Conversation

Dzenly
Copy link
Contributor

@Dzenly Dzenly commented Oct 7, 2018

Fixed a minor copy/paste issue.

Checklist
  • [x ] documentation is changed or added

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Oct 7, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 7, 2018 •
edited
Loading

@Dzenly Thank you!
Our CI lints commit messages according to this format, so now it fails with this notes:

  ✖  5892b76538533405dbedb116aa3b3b0305f5815a
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✖  0:0      Missing subsystem.                        subsystem
     ⚠  0:50     Title should be <= 50 columns.            title-length
     ✖  0:55     Do not use punctuation at end of title.   title-format

The subsystem should be doc: and the period at the title end should be deleted.
If it is not convenient for you to amend the commit message, this can be done by a PR lander though)

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 7, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 4f0971d
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Oct 7, 2018
@Dzenly @vsemozhetbyt
doc: fix minor typo in n-api.md
4f0971d 
Correct parameter name for `napi_is_error` description.

PR-URL: #23310
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 10, 2018
@Dzenly @targos
doc: fix minor typo in n-api.md
4c54f89 
Correct parameter name for `napi_is_error` description.

PR-URL: #23310
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Oct 10, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Dzenly
Copy link
Contributor Author

Dzenly commented Oct 11, 2018 •
edited
Loading

@vsemozhetbyt Thank you for mention of correct format. I will take in into account. Sorry for so late reaction, I made an experiment with my mail and lost some notifications. (

@vsemozhetbyt
Copy link
Contributor

Good luck in other contributions) Thank you again.

jasnell pushed a commit that referenced this pull request Oct 17, 2018
@Dzenly @jasnell
doc: fix minor typo in n-api.md
9fa7c2a 
Correct parameter name for `napi_is_error` description.

PR-URL: #23310
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dzenly @vsemozhetbyt @lpinca @cjihrig @devsnek @nodejs-github-bot