Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: move more deprecations to V8_DEPRECATED #23414

Closed
wants to merge 1 commit into from
Closed

deps: move more deprecations to V8_DEPRECATED #23414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.6',
'v8_embedder_string': '-node.7',

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
Expand Down
48 changes: 24 additions & 24 deletions deps/v8/include/v8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1963,9 +1963,9 @@ class V8_EXPORT JSON {
* \param json_string The string to parse.
* \return The corresponding value if successfully parsed.
*/
static V8_DEPRECATE_SOON("Use the maybe version taking context",
MaybeLocal<Value> Parse(Isolate* isolate,
Local<String> json_string));
static V8_DEPRECATED("Use the maybe version taking context",
MaybeLocal<Value> Parse(Isolate* isolate,
Local<String> json_string));
static V8_WARN_UNUSED_RESULT MaybeLocal<Value> Parse(
Local<Context> context, Local<String> json_string);

Expand Down Expand Up @@ -2065,7 +2065,7 @@ class V8_EXPORT ValueSerializer {
* Returns the stored data. This serializer should not be used once the buffer
* is released. The contents are undefined if a previous write has failed.
*/
V8_DEPRECATE_SOON("Use Release()", std::vector<uint8_t> ReleaseBuffer());
V8_DEPRECATED("Use Release()", std::vector<uint8_t> ReleaseBuffer());

/**
* Returns the stored data (allocated using the delegate's
Expand All @@ -2086,10 +2086,10 @@ class V8_EXPORT ValueSerializer {
/**
* Similar to TransferArrayBuffer, but for SharedArrayBuffer.
*/
V8_DEPRECATE_SOON("Use Delegate::GetSharedArrayBufferId",
void TransferSharedArrayBuffer(
uint32_t transfer_id,
Local<SharedArrayBuffer> shared_array_buffer));
V8_DEPRECATED("Use Delegate::GetSharedArrayBufferId",
void TransferSharedArrayBuffer(
uint32_t transfer_id,
Local<SharedArrayBuffer> shared_array_buffer));

/**
* Indicate whether to treat ArrayBufferView objects as host objects,
Expand Down Expand Up @@ -3439,7 +3439,7 @@ class V8_EXPORT Object : public Value {
V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context,
Local<Value> key);

V8_DEPRECATE_SOON("Use maybe version", bool Delete(Local<Value> key));
V8_DEPRECATED("Use maybe version", bool Delete(Local<Value> key));
V8_WARN_UNUSED_RESULT Maybe<bool> Delete(Local<Context> context,
Local<Value> key);

Expand Down Expand Up @@ -5148,8 +5148,8 @@ class V8_EXPORT SharedArrayBuffer : public Object {
*/
class V8_EXPORT Date : public Object {
public:
static V8_DEPRECATE_SOON("Use maybe version.",
Local<Value> New(Isolate* isolate, double time));
static V8_DEPRECATED("Use maybe version.",
Local<Value> New(Isolate* isolate, double time));
static V8_WARN_UNUSED_RESULT MaybeLocal<Value> New(Local<Context> context,
double time);

Expand Down Expand Up @@ -6408,14 +6408,14 @@ class V8_EXPORT ResourceConstraints {
uint64_t virtual_memory_limit);

// Returns the max semi-space size in MB.
V8_DEPRECATE_SOON("Use max_semi_space_size_in_kb()",
size_t max_semi_space_size()) {
V8_DEPRECATED("Use max_semi_space_size_in_kb()",
size_t max_semi_space_size()) {
return max_semi_space_size_in_kb_ / 1024;
}

// Sets the max semi-space size in MB.
V8_DEPRECATE_SOON("Use set_max_semi_space_size_in_kb(size_t limit_in_kb)",
void set_max_semi_space_size(size_t limit_in_mb)) {
V8_DEPRECATED("Use set_max_semi_space_size_in_kb(size_t limit_in_kb)",
void set_max_semi_space_size(size_t limit_in_mb)) {
max_semi_space_size_in_kb_ = limit_in_mb * 1024;
}

Expand All @@ -6433,12 +6433,12 @@ class V8_EXPORT ResourceConstraints {
void set_max_old_space_size(size_t limit_in_mb) {
max_old_space_size_ = limit_in_mb;
}
V8_DEPRECATE_SOON("max_executable_size_ is subsumed by max_old_space_size_",
size_t max_executable_size() const) {
V8_DEPRECATED("max_executable_size_ is subsumed by max_old_space_size_",
size_t max_executable_size() const) {
return max_executable_size_;
}
V8_DEPRECATE_SOON("max_executable_size_ is subsumed by max_old_space_size_",
void set_max_executable_size(size_t limit_in_mb)) {
V8_DEPRECATED("max_executable_size_ is subsumed by max_old_space_size_",
void set_max_executable_size(size_t limit_in_mb)) {
max_executable_size_ = limit_in_mb;
}
uint32_t* stack_limit() const { return stack_limit_; }
Expand Down Expand Up @@ -7067,9 +7067,9 @@ class V8_EXPORT EmbedderHeapTracer {
* Note: Only one of the AdvanceTracing methods needs to be overriden by the
* embedder.
*/
V8_DEPRECATE_SOON("Use void AdvanceTracing(deadline_in_ms)",
virtual bool AdvanceTracing(
double deadline_in_ms, AdvanceTracingActions actions)) {
V8_DEPRECATED("Use void AdvanceTracing(deadline_in_ms)",
virtual bool AdvanceTracing(
double deadline_in_ms, AdvanceTracingActions actions)) {
return false;
}

Expand Down Expand Up @@ -7108,8 +7108,8 @@ class V8_EXPORT EmbedderHeapTracer {
* Note: Only one of the EnterFinalPause methods needs to be overriden by the
* embedder.
*/
V8_DEPRECATE_SOON("Use void EnterFinalPause(EmbedderStackState)",
virtual void EnterFinalPause()) {}
V8_DEPRECATED("Use void EnterFinalPause(EmbedderStackState)",
virtual void EnterFinalPause()) {}
virtual void EnterFinalPause(EmbedderStackState stack_state);

/**
Expand Down