Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add common defines #23426

Merged

Commits on Nov 5, 2018

  1. build: add common defines

    * `V8_DEPRECATION_WARNINGS` is here for explicity. It is already defined
      in `node.gypi`, and `addon.gypi`.
    * `V8_IMMINENT_DEPRECATION_WARNINGS` added to warn addons authors.
    * `OPENSSL_THREADS` apears in the openSSL `.h` files, and was only
      defined via GYP for the node build.
    
    PR-URL: nodejs#23426
    Fixes: nodejs#23167
    Refs: nodejs#23122
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    refack committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    765766b View commit details
    Browse the repository at this point in the history