-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release proposal: v3.1.0 #2346
Release proposal: v3.1.0 #2346
Commits on Aug 5, 2015
-
build: expand ~ in install prefix early
The install prefix gets written to config.gypi and config.mk. Tildes were expanded in the first file but not in the second one, causing the `make install` target to install files to a directory named `~` in the current working directory. Fixes: nodejs#75 PR-URL: nodejs#2307 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
3Configuration menu - View commit details
-
Copy full SHA for 0bb099f - Browse repository at this point
Copy the full SHA 0bb099fView commit details
Commits on Aug 11, 2015
-
doc: multiple documentation updates cherry picked from v0.12
* doc: improve http.abort description * doc: mention that mode is ignored if file exists * docs: Fix default options for fs.createWriteStream() * Documentation update about Buffer initialization * doc: add a note about readable in flowing mode * doc: Document http.request protocol option * doc, comments: Grammar and spelling fixes * updated documentation for fs.createReadStream * Update child_process.markdown, spelling * doc: Clarified read method with specified size argument. * docs:events clarify emitter.listener() behavior * doc: two minor stream doc improvements * doc: clarify Readable._read and Readable.push * doc: stream.unshift does not reset reading state * doc: readable event clarification * doc: additional refinement to readable event Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noorduis <ben@strongloop.com> PR-URL: nodejs#2302
Configuration menu - View commit details
-
Copy full SHA for 2f154b5 - Browse repository at this point
Copy the full SHA 2f154b5View commit details -
test: address timing issues in simple http tests
simple tests test-http-request-end.js, test-http-default-encoding.js hangs in AIX. The root cause for both the failures is related to the timing with which packets are sent between the client and server. On the client side, one factor that affects the timing is Nagle's algorithm. With Nagle enabled there may be a delay between two packets as the stack may wait until either: a. An acknowledgement for the first packet is received, or b. 200 ms elapses. before sending the second packet. Similarly at the server side 2 sequential packages can be delivered to the application either together or separatly. On AIX we see that they are delivered separately to the server, while on Linux delivered together. If we change the timing, for example disabling Nagle on AIX we see the 2 packets delivered together and the tests pass. In the test case simple/test-http-request-end.js, the client request handler of the server receives and stores the data in a data callback, closes the server in a request end callback, and writes to the client and ends the response, in-line with the request receipt. An HTTP parser module parses the incoming message, and invokes callback routines which are registered for HTTP events (such as header, body, end etc.) Because the termination sequence arrive in a separate packet, there is a delay in parsing that message and identify that the client request ended (and thereby invoke the request end call backhandler). Due to this delay, the response close happens first, which in-turn destroys the server socket leading to the fd and watcher removal from the uv loop abandoning further events on this connection, and end call back never being called, causing the reported hang. simple/test-http-default-encoding.js suffers from the same problem. Also, remove the timer logic from the test case. Test harness anyways contain a timer which controls the individual tests so remove such controls from the test case, as suggested by @tjfontaine Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs/node-v0.x-archive#9432 PORT-FROM: joyent/node @ 13e1131 PR-URL: nodejs#2294 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for c8282de - Browse repository at this point
Copy the full SHA c8282deView commit details -
net: ensure Socket reported address is current
Any time the connection state or the underlying handle itself changes, the socket's name (aka, local address) can change. To deal with this we need to reset the cached sockname any time we set or unset the internal handle or an existing handle establishes a connection. PR-URL: nodejs#2095 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6f89de9 - Browse repository at this point
Copy the full SHA 6f89de9View commit details -
test: make listen-fd-cluster/server more robust
- eliminate unnecessary intermediate process ("parent") - children exit if runner dies unexpectedly (killed on a test timeout, for example) - use explicit messaging from children to parents to indicate when worker is ready to accept http requests, rather than racing to see whether runner will make request before worker is listening PR-URL: nodejs#1944 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <ben@strongloop.com>
Configuration menu - View commit details
-
Copy full SHA for 6ef7aea - Browse repository at this point
Copy the full SHA 6ef7aeaView commit details -
tls: introduce internal
onticketkeycallback
`enableTicketKeyCallback` and `onticketkeycallback` could be potentially used to renew the TLS Session Tickets before they expire. However this commit will introduce it only for private use yet, because we are not sure about the API, and already need this feature for testing. See: nodejs#2304 PR-URL: nodejs#2312 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Configuration menu - View commit details
-
Copy full SHA for 51b6bdc - Browse repository at this point
Copy the full SHA 51b6bdcView commit details -
tls: fix check for reused session
When TLS Session Ticket is renewed by server - no Certificate record is to the client. We are prepared for empty certificate in this case, but this relies on the session reuse check, which was implemented incorrectly and was returning false when the TLS Session Ticket was renewed. Use session reuse check provided by OpenSSL instead. Fix: nodejs#2304 PR-URL: nodejs#2312 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Configuration menu - View commit details
-
Copy full SHA for 581850b - Browse repository at this point
Copy the full SHA 581850bView commit details -
util: display constructor when inspecting objects
This commit modifies util.inspect(obj) to additionally show the name of the function that constructed the object. This often reveals useful information about the object's prototype. In other words, instead of > new Cls {} we have > new Cls Cls {} This also works with exotic objects: > class ArrayCls extends Array {} > new ArrayCls(1, 2, 3) ArrayCls [ 1, 2, 3 ] The names of "trivial" constructors like Object and Array are not shown, unless there is a mismatch between the object representation and the prototype: > Object.create([]) Array {} This feature is inspired by browser devtools. PR-URL: nodejs#1935 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee9dd68 - Browse repository at this point
Copy the full SHA ee9dd68View commit details -
build: update manifest to include Windows 10
Windows 10 wasn't listed in the executable manifest. This caused problems with trying to detect Windows 10 via `os.release()`. PR-URL: nodejs#2332 Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 3a48c72 - Browse repository at this point
Copy the full SHA 3a48c72View commit details -
path: remove dead code in favor of unit tests
Remove dead code paths that are created by assertions that will never trigger. They may only trigger if either the `splitDeviceRe` or `splitPathRe` regular expressions are modified. If at some point they are modified, current unit tests will catch most of the resulting errors and this commit adds extra tests to catch the remaining errors. PR-URL: nodejs#2282 Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 4750a2a - Browse repository at this point
Copy the full SHA 4750a2aView commit details -
test: clarify dropMembership() call
According to docs, dropMembership() is automatically called by the kernel when the socket is closed, and most apps will never need to call it. It's called here as a sanity check only so let's note that with a comment. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: nodejs#2062
Configuration menu - View commit details
-
Copy full SHA for bed03ea - Browse repository at this point
Copy the full SHA bed03eaView commit details