Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect expectation order #23466

Closed
wants to merge 3 commits into from
Closed

fix incorrect expectation order #23466

wants to merge 3 commits into from

Conversation

sunburntkamel
Copy link
Contributor

fix an instance of the test value and the expected value being reversed

Refs: https://nodejs.org/api/assert.html

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Amie added 3 commits October 12, 2018 09:33
Tests: fix incorrect expectation order
8285bdb 
test-http-expect-handling.js has an instance of the test value and the expected value being reversed

Refs: https://nodejs.org/api/assert.html
tests: fix incorrect expectation order
5423022 
fix an instance of the test value and the expected value being reversed

Refs: https://nodejs.org/api/assert.html
Merge branch 'master' of https://github.com/sunburntkamel/node
710dca7
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17800

@Trott
Copy link
Member

Trott commented Oct 13, 2018

Collaborators, please 👍 here to approve fast-tracking.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 13, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 13, 2018
@Trott
test: fix incorrect expectation order
c23d250 
test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: nodejs#23466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Landed in c23d250.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@addaleax
test: fix incorrect expectation order
6fb488f 
test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: #23466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasnell
test: fix incorrect expectation order
722e0d4 
test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: #23466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@MylesBorins
test: fix incorrect expectation order
f8e7112 
test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: #23466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
test: fix incorrect expectation order
6d01165 
test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: #23466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
test: fix incorrect expectation order
6ca3876 
test-http-expect-handling.js has an instance of the test value and the
expected value being reversed.

Refs: https://nodejs.org/api/assert.html

PR-URL: #23466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sunburntkamel @Trott @jasnell @thefourtheye @cjihrig @gireeshpunathil @targos @nodejs-github-bot