Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap actual and expected in assertions #23474

Closed
wants to merge 2 commits into from
Closed

swap actual and expected in assertions #23474

wants to merge 2 commits into from

Commits on Oct 12, 2018

  1. test: swap actual and expected in assertions 

    'test/parallel/test-fs-write.js' contains assertions where the first
argument provided is the expected value and the second value is the
actual value. This is backward from the documentation for assertions
like 'assert.strictEqual()' where the first value should be the actual
value being tested and the second value is the expected value.
    @yitongding
    yitongding committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    fff9705 View commit details
    Browse the repository at this point in the history

  2. test: replace function with arrow function

    @yitongding
    yitongding committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    31d05ab View commit details
    Browse the repository at this point in the history