Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix/improve persistent repl history #2356

Merged
merged 2 commits into from
Oct 19, 2015
Merged

repl: fix/improve persistent repl history #2356

merged 2 commits into from
Oct 19, 2015

Commits on Oct 19, 2015

  1. test: cleanup, improve repl-persistent-history 

    - Now cleans up the history file unless told otherwise.
- Now also logs which test case failed.
- Waits for flush after repl close if necessary.

Fixes: nodejs#2319
PR-URL: nodejs#2356
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed By: Evan Lucas <evanlucas@me.com>
    @Fishrock123
    Fishrock123 committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    286ef1d View commit details
    Browse the repository at this point in the history

  2. repl: limit persistent history correctly on load 

    Previously the wrong end of the history was limited on load.

PR-URL: nodejs#2356
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed By: Evan Lucas <evanlucas@me.com>
    @Fishrock123
    Fishrock123 committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    73b7e05 View commit details
    Browse the repository at this point in the history