Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix order of parameters to assert.strictEqual #23590

Closed
wants to merge 1 commit into from
Closed

test: fix order of parameters to assert.strictEqual #23590

wants to merge 1 commit into from

Commits on Oct 14, 2018

  1. test: fix order of parameters to assert.strictEqual 

    Usage of assert.strictEqual in test-net-server-listen-remove-callback.js
incorrectly passes the expected value as the first argument
and actual value as the second argument.

This should be reversed, per the assert documentation.

Refs: https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message
    @jasonnutter
    jasonnutter committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    e8e5ea3 View commit details
    Browse the repository at this point in the history