Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix errors in test-buffer-alloc.js #23645

Closed
wants to merge 1 commit into from
Closed

test: fix errors in test-buffer-alloc.js #23645

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 13, 2018

This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 13, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1233/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 13, 2018
@Trott
Copy link
Member Author

Trott commented Oct 13, 2018

Collaborators, please 👍 here to fast-track.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17826/

@Trott
test: fix errors in test-buffer-alloc.js
b0ca46e 
This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.
Trott added a commit to Trott/io.js that referenced this pull request Oct 13, 2018
@Trott
test: fix errors in test-buffer-alloc.js
401dac3 
This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.

PR-URL: nodejs#23645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 13, 2018

Landed in 401dac3

@Trott Trott closed this Oct 13, 2018
@addaleax addaleax mentioned this pull request Oct 16, 2018
Closed
4 tasks
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@Trott @jasnell
test: fix errors in test-buffer-alloc.js
2d2388d 
This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.

PR-URL: #23645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @fhinkel @addaleax