Code and learn rollup 2 #23651
Closed
Code and learn rollup 2 #23651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertion arguments should have the first value be the actual value, while the second value be the expected value.
src: remove delete MessagePort.prototype.hasRef; Node Code+Learn: remote delete MessagePort.prototype.hasRef;
'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value.
|
I’ll land these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not land. Rolling up 5 Code & Learn commits so I can run CI on them once rather than needing to run CI 5 times...
#23470
#23471
#23472
#23473
#23474