Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add missing ares_android.h file #23682

Merged
merged 1 commit into from
Oct 19, 2018
Merged

deps: add missing ares_android.h file #23682

merged 1 commit into from
Oct 19, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 16, 2018

This file was left out of the c-ares 1.14.0 update.

Haven't/can't test this myself.

Fixes: #23681

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1256/pipeline

@nodejs-github-bot nodejs-github-bot added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Oct 16, 2018
@cjihrig cjihrig mentioned this pull request Oct 16, 2018
Closed
@lundibundi
Copy link
Member

lundibundi commented Oct 16, 2018 •
edited by cjihrig
Loading

Sanity CI: https://ci.nodejs.org/job/node-test-pull-request/17889/

Based on feedback #23681 (comment) this seems to fix things.

EDIT(cjihrig): Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17904/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2018
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17958/

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 18, 2018

Green resumed CI: https://ci.nodejs.org/job/node-test-pull-request/17970/

@cjihrig
deps: add missing ares_android.h file
1d5aba1 
This file was left out of the c-ares 1.14.0 update.

PR-URL: nodejs#23682
Fixes: nodejs#23681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 1d5aba1 into nodejs:master Oct 19, 2018
@cjihrig cjihrig deleted the cares branch October 19, 2018 12:32
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@cjihrig @addaleax
deps: add missing ares_android.h file
850ba35 
This file was left out of the c-ares 1.14.0 update.

PR-URL: #23682
Fixes: #23681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@cjihrig @jasnell
deps: add missing ares_android.h file
c4e74ec 
This file was left out of the c-ares 1.14.0 update.

PR-URL: #23682
Fixes: #23681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@cjihrig @MylesBorins
deps: add missing ares_android.h file
44279e0 
This file was left out of the c-ares 1.14.0 update.

PR-URL: #23682
Fixes: #23681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@cjihrig @rvagg
deps: add missing ares_android.h file
49af239 
This file was left out of the c-ares 1.14.0 update.

PR-URL: #23682
Fixes: #23681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@cjihrig @MylesBorins
deps: add missing ares_android.h file
06782fe 
This file was left out of the c-ares 1.14.0 update.

PR-URL: #23682
Fixes: #23681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @lundibundi @apapirovski @refack @jasnell @addaleax @BridgeAR