Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: migrate from process.binding('config') to getOptions() #23684

Closed
wants to merge 1 commit into from
Closed

repl: migrate from process.binding('config') to getOptions() #23684

wants to merge 1 commit into from

Conversation

jbucio2
Copy link
Contributor

@jbucio2 jbucio2 commented Oct 16, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 16, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 16, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17900/

@jbucio2
Copy link
Contributor Author

jbucio2 commented Oct 17, 2018

@addaleax I see there are a 2 failures in the build CI, is there something I need to do to resolve the failures? Thanks!

@jasnell
Copy link
Member

jasnell commented Oct 17, 2018

Those failures should be unrelated.
Going to try to run them again: https://ci.nodejs.org/job/node-test-pull-request/17927/

@jbucio2
Copy link
Contributor Author

jbucio2 commented Oct 17, 2018

@jasnell it looks like there are two check failures node-test-commit and node-test-linux-linked-debug

@addaleax
Copy link
Member

addaleax commented Oct 17, 2018 •
edited by BridgeAR
Loading

… Resume build again: https://ci.nodejs.org/job/node-test-pull-request/17931/ ✔️ (green besides linux-containered)

@BridgeAR
Copy link
Member

Rebuild linux-containered https://ci.nodejs.org/job/node-test-commit-linux-containered/7909/

@jbucio2
Copy link
Contributor Author

jbucio2 commented Oct 18, 2018

there still appears to be build failures on the re-run

@addaleax
Copy link
Member

… again: https://ci.nodejs.org/job/node-test-commit-linux-containered/7992/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 22, 2018
@Trott
repl: migrate from process.binding('config') to getOptions()
f1b9546 
PR-URL: nodejs#23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 22, 2018

Landed in f1b9546.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Oct 22, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
@targos
repl: migrate from process.binding('config') to getOptions()
86cf014 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@MylesBorins
repl: migrate from process.binding('config') to getOptions()
d1c0827 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
repl: migrate from process.binding('config') to getOptions()
753eb38 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
repl: migrate from process.binding('config') to getOptions()
307b277 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jbucio2 @addaleax @jasnell @BridgeAR @Trott @thefourtheye @cjihrig @MylesBorins @nodejs-github-bot