Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify fd behaviour with {read,write}File #23706

Closed
wants to merge 7 commits into from
Closed

doc: clarify fd behaviour with {read,write}File #23706

wants to merge 7 commits into from

Commits on Oct 17, 2018

  1. doc: clarify fd behaviour with {read,write}File

    @thefourtheye
    thefourtheye committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    351d9df View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. address @vsemozhetbyt's comments

    @thefourtheye
    thefourtheye committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    5370c14 View commit details
    Browse the repository at this point in the history

  2. changes because of nodejs#23709

    @thefourtheye
    thefourtheye committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    b5a440c View commit details
    Browse the repository at this point in the history

  3. group the relevant parts

    @thefourtheye
    thefourtheye committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    d44bf9f View commit details
    Browse the repository at this point in the history

  4. update fs promisified functions' behaviour

    @thefourtheye
    thefourtheye committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    121e1dd View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. Revert "changes because of nodejs#23709" 

    This reverts commit b5a440c.
    @thefourtheye
    thefourtheye committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    9975e9a View commit details
    Browse the repository at this point in the history

  2. address review comments

    @thefourtheye
    thefourtheye committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    ef290a7 View commit details
    Browse the repository at this point in the history