Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix shim for v8::Value::IntegerValue() #23898

Closed
wants to merge 1 commit into from
Closed

deps: fix shim for v8::Value::IntegerValue() #23898

wants to merge 1 commit into from

Commits on Oct 26, 2018

  1. deps: fix shim for v8::Value::IntegerValue() 

    This was introduced in 48d1335. Previously, values such as
`undefined` would not be coerced properly because `NumberValue()`
returns `NaN` for them.

Refs: nodejs#23158
    @addaleax
    addaleax committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    a96358f View commit details
    Browse the repository at this point in the history