Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: throw exception when creating from non-Node.js Context #23938

Closed
wants to merge 1 commit into from
Closed

buffer: throw exception when creating from non-Node.js Context #23938

wants to merge 1 commit into from

Commits on Oct 28, 2018

  1. buffer: throw exception when creating from non-Node.js Context 

    Throw an exception instead of crashing when attempting to create
`Buffer` objects from a Context that is not associated with
a Node.js `Environment`.

Possible alternatives for the future might be just returning
a plain `Uint8Array`, or working on providing `Buffer` for all
`Context`s.
    @addaleax
    addaleax committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    b7dd1c5 View commit details
    Browse the repository at this point in the history