Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add SECURITY.md to readme.md #24031

Closed
wants to merge 2 commits into from
Closed

doc: add SECURITY.md to readme.md #24031

wants to merge 2 commits into from

Conversation

warnerp18
Copy link
Contributor

This adds a SECURITY.md file and links to the security document per the
request of @Trott at a recent SF Node meetup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@warnerp18
doc: add SECURITY.md to readme.md
692c162 
This adds a SECURITY.md file and links to the security document per the
request of @https://github.com/Trott at a recent SF Node meetup.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 2, 2018
richardlau
richardlau reviewed Nov 2, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Nov 2, 2018
View reviewed changes
README.md Outdated

When in doubt, please do send us a report.

For information about security of the Node.js project, see [SECURITY.md](https://github.com/nodejs/node/blob/master/SECURITY.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For information about security of the Node.js project, see [SECURITY.md](https://github.com/nodejs/node/blob/master/SECURITY.md).
For information on reporting security vulnerabilities in Node.js, see
[SECURITY.md](./SECURITY.md).

Trott
Trott reviewed Nov 2, 2018
View reviewed changes
SECURITY.md Show resolved Hide resolved
Trott
Trott approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple nits, but LGTM.

vsemozhetbyt
vsemozhetbyt approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With other suggestions addressed.

SECURITY.md Outdated
Response Team thinks of them. When in doubt, please do send us a report
nonetheless.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unneeded empty line can be deleted.

refack
refack approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

@refack refack added meta Issues and PRs related to the general management of the project. security Issues and PRs related to security. labels Nov 2, 2018
@Trott
Copy link
Member

Trott commented Nov 2, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1463/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 2, 2018
@Trott Trott force-pushed the add-security-md-file branch from 6f05508 to f9f7212 Compare November 4, 2018 07:06
@Trott
Copy link
Member

Trott commented Nov 4, 2018

Landed in 472a3d8.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 4, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 4, 2018
@warnerp18 @Trott
doc: add SECURITY.md to readme.md
472a3d8 
This adds a SECURITY.md file and links to the security document per the
request of @https://github.com/Trott at a recent SF Node meetup.

PR-URL: nodejs#24031
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 5, 2018
@warnerp18 @targos
doc: add SECURITY.md to readme.md
fa84164 
This adds a SECURITY.md file and links to the security document per the
request of @https://github.com/Trott at a recent SF Node meetup.

PR-URL: #24031
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@warnerp18 @codebytere
doc: add SECURITY.md to readme.md
fbbb5b7 
This adds a SECURITY.md file and links to the security document per the
request of @https://github.com/Trott at a recent SF Node meetup.

PR-URL: #24031
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@warnerp18 @MylesBorins
doc: add SECURITY.md to readme.md
4fb93d1 
This adds a SECURITY.md file and links to the security document per the
request of @https://github.com/Trott at a recent SF Node meetup.

PR-URL: #24031
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@warnerp18 @MylesBorins
doc: add SECURITY.md to readme.md
6dc0a1c 
This adds a SECURITY.md file and links to the security document per the
request of @https://github.com/Trott at a recent SF Node meetup.

PR-URL: #24031
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. security Issues and PRs related to security.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@warnerp18 @Trott @refack @lpinca @richardlau @vsemozhetbyt @codebytere @nodejs-github-bot