Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: gather all errors constant in the same place for consistency #24038

Closed
wants to merge 1 commit into from
Closed

lib: gather all errors constant in the same place for consistency #24038

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Nov 2, 2018

Gather all errors constant in the same place for consistency in lib/net.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Nov 2, 2018
@joyeecheung joyeecheung added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Nov 2, 2018
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18303/

@Trott
Copy link
Member

Trott commented Nov 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18653/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 15, 2018
@Trott
Copy link
Member

Trott commented Nov 15, 2018

Landed in 1ddcccb

@Trott Trott closed this Nov 15, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 15, 2018
@ZYSzys @Trott
lib: gather all errors constant in the same place for consistency
1ddcccb 
PR-URL: nodejs#24038
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ZYSzys ZYSzys deleted the net/error branch November 16, 2018 01:12
targos pushed a commit that referenced this pull request Nov 18, 2018
@ZYSzys @targos
lib: gather all errors constant in the same place for consistency
6de40c4 
PR-URL: #24038
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ZYSzys @rvagg
lib: gather all errors constant in the same place for consistency
bc5a0d3 
PR-URL: #24038
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@ZYSzys @codebytere
lib: gather all errors constant in the same place for consistency
3450a4c 
PR-URL: #24038
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZYSzys @joyeecheung @Trott @jasnell @lpinca @cjihrig @nodejs-github-bot