Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.0.276.35 #24056

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.0.276.35 #24056

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 3, 2018

Refs: v8/v8@7.0.276.32...7.0.276.35

/cc @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 3, 2018
@targos
Copy link
Member Author

targos commented Nov 3, 2018

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 3, 2018
@targos
Copy link
Member Author

targos commented Nov 5, 2018

Landed in 5c2d555

@targos targos closed this Nov 5, 2018
@targos targos deleted the v8-35 branch November 5, 2018 19:02
targos added a commit that referenced this pull request Nov 5, 2018
Refs: v8/v8@7.0.276.32...7.0.276.35

PR-URL: #24056
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos targos added dont-land-on-v6.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 5, 2018
targos added a commit that referenced this pull request Nov 6, 2018
Refs: v8/v8@7.0.276.32...7.0.276.35

PR-URL: #24056
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants