Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: move module exports proxy into a separate method #24057

Closed
wants to merge 1 commit into from
Closed

lib: move module exports proxy into a separate method #24057

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

@joyeecheung
lib: move module exports proxy into a separate method
3e21909 
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.
@joyeecheung joyeecheung requested a review from devsnek November 3, 2018 15:03
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1467/pipeline

@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18312/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 3, 2018
@danbev
Copy link
Contributor

danbev commented Nov 6, 2018

Landed in c3b674c.

@danbev danbev closed this Nov 6, 2018
danbev pushed a commit that referenced this pull request Nov 6, 2018
@joyeecheung @danbev
lib: move module exports proxy into a separate method
c3b674c 
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2018
@joyeecheung @targos
lib: move module exports proxy into a separate method
879c0f1 
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@joyeecheung joyeecheung mentioned this pull request Nov 24, 2018
Closed
3 tasks
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@joyeecheung @codebytere
lib: move module exports proxy into a separate method
783acac 
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@joyeecheung @MylesBorins
lib: move module exports proxy into a separate method
4cb822e 
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@joyeecheung @MylesBorins
lib: move module exports proxy into a separate method
8ef5de5 
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.

PR-URL: #24057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@addaleax addaleax addaleax approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @nodejs-github-bot @danbev @refack @addaleax @devsnek @codebytere